Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail if server is not not set in env. #1670

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Do not fail if server is not not set in env. #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/malloy-db-trino/src/trino_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,13 +442,8 @@ export class TrinoConnection implements Connection, PersistSQLResults {
}*/

public async estimateQueryCost(_sqlCommand: string): Promise<QueryRunStats> {
/*const dryRunResults = await this.dryRunSQLQuery(sqlCommand);
return {
queryCostBytes: Number(
dryRunResults.metadata.statistics.totalBytesProcessed
),
};*/
throw new Error('Not impld 6');
// TODO(figutierrez): Implement.
return {};
}

public async executeSQLRaw(_sqlCommand: string): Promise<QueryData> {
Expand Down
4 changes: 0 additions & 4 deletions packages/malloy-db-trino/src/trino_executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ export class TrinoExecutor {
catalog,
schema,
};
} else {
throw new Error(
'Tried to get Trino connection from Env, no TRINO_SERVER specified.'
);
}

return undefined;
Expand Down
Loading