Migrate highlight file refernces to use @malloydata/syntax-highlight #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whscullin
reviewed
Sep 16, 2023
There was a problem hiding this comment.
You should delete the old files, and make sure to add an exception to .vscodeignore for the module like here: https://github.com/malloydata/malloy-vscode-extension/blob/main/.vscodeignore#L5
whscullin
reviewed
Sep 16, 2023
| @@ -13,6 +13,6 @@ | |||
| "noImplicitAny": true, | |||
| "strict": true | |||
| }, | |||
| "include": ["./src"], | |||
| "include": ["./src", "./node_modules/@malloydata/syntax-highlight/grammars"], | |||
There was a problem hiding this comment.
This probably isn't necessary.
whscullin
reviewed
Sep 16, 2023
|
/gcbrun |
mtoy-googly-moogly
added a commit
that referenced
this pull request
Sep 20, 2023
mtoy-googly-moogly
added a commit
that referenced
this pull request
Sep 20, 2023
Move package highlight code from PR #245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.