Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variables to setup map centering #22

Merged

Conversation

CBalsier
Copy link
Collaborator

Fixes issue #10

Bear with me, it’s the first time I’m writing Typescript anything 🙈

I followed this tutorial https://dev.to/hackmamba/how-to-create-environment-variables-in-nuxtjs-2dh4 which did end up working (I found the official doc not that clear :/).

How to test:

  • run the app as usual without touching anything -> by default the map should be setup as in the current demo (on Toulouse)
  • copy the .env.example file to .env and change the coordinates to anywhere else (preferably far away, to be able to see the change better)
  • reload the page: the map centering should change

I wrote a small paragraph in the README to explain but feel free to ask for precisions if needed!

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for recolto ready!

Name Link
🔨 Latest commit a4c2cc3
🔍 Latest deploy log https://app.netlify.com/sites/recolto/deploys/678824339e112c0008faa198
😎 Deploy Preview https://deploy-preview-22--recolto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBalsier
Copy link
Collaborator Author

pinging @SimonMellerin for a review 🙏

Copy link
Member

@SimonMellerin SimonMellerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work !

@SimonMellerin SimonMellerin merged commit 4c539e2 into makinacorpus:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants