Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14 - Bootstrap documentation #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SimonMellerin
Copy link
Member

A first work for a documentation on ReadTheDocs built with Vitepress

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for recolto ready!

Name Link
🔨 Latest commit 66931f2
🔍 Latest deploy log https://app.netlify.com/sites/recolto/deploys/6788c91cc104e80008bec593
😎 Deploy Preview https://deploy-preview-21--recolto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@CBalsier CBalsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey 👋 spent some time discovering the tool and how it works, there is a small config point that I don’t understand, but else all comments are minor ones linked to typos or formatting

docs/content/contribuer.md Outdated Show resolved Hide resolved
tools:
nodejs: "18"
commands:
- mkdir --parents $READTHEDOCS_OUTPUT/html/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is $READTHEDOCS_OUTPUT defined? (as well as $READTHEDOCS_LANGUAGE, and VERSION)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/content/sources-donnees.md Outdated Show resolved Hide resolved
docs/content/contribuer.md Outdated Show resolved Hide resolved
{ icon: 'github', link: 'https://github.com/makinacorpus/recolto' }
],
sidebar: generateSidebar({
documentRootPath: 'content',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did make some tests right here:

  • with the suggested "content": got the following error:
failed to load config from /Users/…/dev/recolto-makina/docs/.vitepress/config.ts
failed to start server. error:
ENOENT: no such file or directory, scandir '/Users/gnome/dev/recolto-makina/content'
Error: ENOENT: no such file or directory, scandir '/Users/gnome/dev/recolto-makina/content'
  • with "/" I had a working vitepress with a sidebar (including docs, README.md) but all individual pages were 404
  • with "docs/content" I get a working sidebar only with the items in "content" + the pages, I assume that’s the expected result?

-> suggestion

Suggested change
documentRootPath: 'content',
documentRootPath: 'docs/content',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, my bad, my readme is not explicit enough 😬

You need to launch every commands in the docs folder.: cd docs. Then it should work properly

docs/content/sources-donnees.md Outdated Show resolved Hide resolved
docs/content/sources-donnees.md Outdated Show resolved Hide resolved
docs/content/sources-donnees.md Outdated Show resolved Hide resolved
Actuellement, nous utilisons les données de Copernicus pour estimer les précipitations globales. Cependant, nous sommes en train de passer à l'API de Météo France afin d'améliorer la précision des données pluviométriques et de fournir des informations plus fiables adaptées à des lieux spécifiques.
- **estimation de la consommation d'eau mensuelle:**
Les calculs de consommation d'eau sont basés sur les statistiques nationales fournies par le Centre d'information sur l'eau, garantissant un reflet précis des habitudes de consommation.
- **calculer le prix de l'eau:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **calculer le prix de l'eau:**
- **calculer le prix de l'eau :**

docs/content/sources-donnees.md Outdated Show resolved Hide resolved
@SimonMellerin
Copy link
Member Author

@CBalsier Thanks for the careful review!

I have resolved all your typo suggestions. I let you close the remaining suggestions if it's ok for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants