Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bowling challenge #1604

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bowling challenge #1604

wants to merge 5 commits into from

Conversation

carolrs
Copy link

@carolrs carolrs commented May 2, 2023

No description provided.

tomcarmichael
tomcarmichael reviewed May 2, 2023
View reviewed changes
Copy link

@tomcarmichael tomcarmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - well done Ana! As we discussed could maybe have unit tests as the only improvement I can think of!

bowling/frame.js
}

isStrike(){
return this.rolls[0] === 10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! terse way to write

bowling/frame.js
}

score(){
let sum = this.rolls.reduce((acc, number) => acc + number)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great use of reduce

bowling/score.js

}

addFrame(...rolls){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

tomcarmichael
tomcarmichael reviewed May 2, 2023
View reviewed changes
bowling/score.js


} //spare
else if (currentFrame.isSpare() && this.hasNext(i)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider breaking this out into a separate function as this function is a little long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomcarmichael tomcarmichael tomcarmichael left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolrs @tomcarmichael