[WEB-2257] fix: empty state change for space archive and no issues #5440
Conversation
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IssueLayoutHOC
participant EmptyState
User->>IssueLayoutHOC: Request to view issues
IssueLayoutHOC->>IssueLayoutHOC: Check for issues
alt No issues found
IssueLayoutHOC->>EmptyState: Render with theme-aware image and description
EmptyState-->>User: Display empty state
else Issues found
IssueLayoutHOC->>User: Display list of issues
end
Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- space/core/components/common/empty-state.tsx (1 hunks)
- space/core/components/issues/issue-layouts/issue-layout-HOC.tsx (3 hunks)
Additional comments not posted (8)
space/core/components/common/empty-state.tsx (4)
1-20: LGTM!The imports and type definition are correct and well-defined.
The code changes are approved.
22-30: LGTM!The component definition and structure are correct and follow best practices.
The code changes are approved.
31-33: LGTM!The Image and title rendering are correct and follow best practices.
The code changes are approved.
34-47: LGTM!The description and button rendering are correct and follow best practices for conditional rendering and dynamic properties.
The code changes are approved.
space/core/components/issues/issue-layouts/issue-layout-HOC.tsx (4)
2-8: LGTM!The imports are correct and necessary for the new functionality.
The code changes are approved.
21-23: LGTM!The component definition and theme usage are correct and follow best practices for theme-aware rendering.
The code changes are approved.
Line range hint
24-36: LGTM!The loader and issue count handling are correct and follow best practices for conditional rendering based on state.
The code changes are approved.
37-44: LGTM!The empty state rendering is correct and enhances the user experience by providing a visually informative display.
The code changes are approved.
sharma01ketan
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- space/core/components/issues/issue-layouts/issue-layout-HOC.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- space/core/components/issues/issue-layouts/issue-layout-HOC.tsx
[WEB-2257]
Changes:
This PR changes the UI rendered in "spaces" when the project is archived or has no issues.
For both light and dark mode
References:
[WEB-2257]
Summary by CodeRabbit
Summary by CodeRabbit
New Features
EmptyStatecomponent for displaying user-friendly placeholders when no content is available.IssueLayoutHOCto utilize theEmptyStatecomponent, providing a visually informative message when no issues are found, with responsiveness to light or dark themes.Bug Fixes
EmptyStatedisplay.