-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Refresh s3 links in projects and issues #3165
base: develop
Are you sure you want to change the base?
Feat/Refresh s3 links in projects and issues #3165
Conversation
… and AWS_S3_MAX_AGE_SECONDS to config file
@daniel-alba17, thanks for creating the PR we will review this and get back. |
daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this one?
plane/apiserver/plane/app/views/project/base.py
Lines 581 to 591 in 3a466cf
s3 = boto3.client( | |
"s3", | |
aws_access_key_id=settings.AWS_ACCESS_KEY_ID, | |
aws_secret_access_key=settings.AWS_SECRET_ACCESS_KEY, | |
) | |
params = { | |
"Bucket": settings.AWS_STORAGE_BUCKET_NAME, | |
"Prefix": "static/project-cover/", | |
} | |
response = s3.list_objects_v2(**params) |
Something should be done with the following errors too
An error occurred (InvalidAccessKeyId) when calling the ListObjectsV2 operation: The AWS Access Key Id you provided does not exist in our records.
GET - /api/project-covers/ of Queries: 1
Internal Server Error: /api/project-covers/
172.22.1.1:32020 - "GET /api/project-covers/ HTTP/1.1" 500
There is a new issue #4248 about that last error |
5381868
to
9143e5a
Compare
🎯 Milestone
Refresh s3 links in issue body and project cover if bucket is private
🛠 Changes