added jiahong ET-44W Thermostat #2718
Conversation
Combined primary_entity and secondary_entities into a single entities list.
| value: auto | ||
| - dps_val: "hold" | ||
| value: heat | ||
| - dps_val: "holiday" |
There was a problem hiding this comment.
I don't think this is correct. Holiday mode is not cool. It is probably better to make these preset_modes and have hvac_mode just switch between heat and off.
| @@ -0,0 +1,194 @@ | |||
| name: Jiahong ET-44W thermostat | |||
There was a problem hiding this comment.
Branding should be under a products section (requires product id).
For top level name, I suggest just Thermostat.
Reasoning:
- HA prefixes device names in various places in the UI, so it is better to keep it short.
- Other devices may match the same config (likely same device sold under different brands around the world), so default name without branding is less likely to confuse.
- if a user has multiple thermostats, they can always rename the device (they would need to anyway if they are the same brand and model).
There was a problem hiding this comment.
I have the same device but it's called "TheroLife ET-44(w)" and find it like "ET-44W x4.44 WiFi Thermostat" at our marketplaces so it's better to give it short name ET-44W
There was a problem hiding this comment.
This is precisely why I am suggesting above to make the top level name just "Thermostat". Someone else might also find the same product in their market being sold as DS-33X.
| constraint: temperature_unit | ||
| conditions: | ||
| - dps_val: true | ||
| step: 30 |
There was a problem hiding this comment.
This is a bit strange. I would expect a step of 10 for Fahrenheit, and a range close to what the Celsius range is (5-40C = 41-104F, so I expect maybe 400-1000 or 410-1040 for the range)
There was a problem hiding this comment.
{\"abilityId\":16,\"accessMode\":\"rw\",\"code\":\"temp_set\",\"description\":\"range in C with step 5, 5----40℃\\n range in F with step 10, 41--104℉\\nholiday range in C with step 5, 5----15℃\\n range in F with step 10 , 41---59℉\",\"extensions\":{\"iconName\":\"icon-dp_temp\",\"attribute\":\"2\"},\"name\":\"target temperature\",\"typeSpec\":{\"type\":\"value\",\"max\":400,\"min\":50,\"scale\":1,\"step\":5,\"unit\":\"℃\"}},
I got this from Tuya API. Descriptions were translated from Chinese by google. And "holiday" likely cool mode or somehow to keep floor temperature above 0 C
| - id: 109 | ||
| type: integer | ||
| name: holiday_days | ||
| - id: 112 |
There was a problem hiding this comment.
112 and 113 are room temperature calibration and floor temperature calibration for ET72W (recently discovered). Maybe the same for this model, but 103 is different (integer vs boolean) so not guaranteed.
| type: integer | ||
| name: unknown_113 | ||
| - entity: lock | ||
| name: Screen lock |
There was a problem hiding this comment.
Use translation_key: child_lock is better I think, then icon mappings can be removed.
| icon: "mdi:hand-back-right-off" | ||
| - dps_val: false | ||
| icon: "mdi:hand-back-right" | ||
| - entity: sensor |
There was a problem hiding this comment.
Don't duplicate the temperature here, it is already available in the climate entity.
ET72 does it because there are two sensors for room temperature and floor temperature (and also it is an old config and not following up to date best practice)
added a template for the ET-44W electric underfloor heating thermostat, based on the existing ET-72W