Remove unnecessary warning for empty magpie runs #583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐦 Description of this PR 🐦
(As I never did a MAgPIE PR before, please help me fill out the stuff correctly etc. If my fix is not what you want, please adapt it yourself… I do not even have the right to add reviewers and labels, so please, @dklein-pik and @pfuehrlich-pik, you have to take over)
Running the REMIND-MAgPIE coupled tests prints a warning to the logs:
This comes from setting cfg$gms$c_input_gdx_path in start_functions.R for empty model runs, but not having set this elsewhere. Therefore, I adapted the extras in
check_config
to simply accept that.🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
/p/tmp/oliverr/magpie/logs/compilation_check-27091543.out
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly