Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warning for empty magpie runs #583

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Aug 2, 2023

🐦 Description of this PR 🐦

(As I never did a MAgPIE PR before, please help me fill out the stuff correctly etc. If my fix is not what you want, please adapt it yourself… I do not even have the right to add reviewers and labels, so please, @dklein-pik and @pfuehrlich-pik, you have to take over)

Running the REMIND-MAgPIE coupled tests prints a warning to the logs:

Settings are unknown in provided cfg (cfg$gms$c_input_gdx_path)!

This comes from setting cfg$gms$c_input_gdx_path in start_functions.R for empty model runs, but not having set this elsewhere. Therefore, I adapted the extras in check_config to simply accept that.

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
      • see /p/tmp/oliverr/magpie/logs/compilation_check-27091543.out
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

@orichters orichters changed the base branch from master to develop August 2, 2023 09:33
@orichters orichters marked this pull request as draft August 2, 2023 09:35
@orichters orichters marked this pull request as ready for review August 8, 2023 15:22
@pfuehrlich-pik pfuehrlich-pik merged commit 45136f6 into magpiemodel:develop Aug 16, 2023
1 check passed
@orichters orichters deleted the c_input_gdx_path branch April 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low risk Low risk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants