Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File name collision fix and minor extentions #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anton-bushuiev
Copy link

@anton-bushuiev anton-bushuiev commented Oct 30, 2022

This pull request fixes one bug and adds two minor extensions of the current functionality:

  1. Fix output file names collision. If you currently run match_pairs.py on scannet_test_pairs_with_gt.txt you get only 1248 output files instead of 1500 because of the same names for frames in different scenes. This pull request adds function pair_names_to_id which constructs a unique id for each pair based on the complete paths of an image pair and can be easily parsed.
  2. Add padding to allow any image resolution. If you currently, for example, run match_pairs.py with --resize 648, 484 you get an output of 648x480 since 484 is not divisible by 8. This pull request adds zero padding to preserve the original resolution.
  3. Add support for custom keypoints. This is implemented via an additional argument for match_pairs.py. The argument --input_points is a path to a directory with the tensors containing custom keypoints. Naming convention of keypoint files is the same as for output matching files. The example of a SuperGlue matching of line segment endpoints:
    image
    image

@anton-bushuiev anton-bushuiev changed the title Bug fix and minor extentions File name collision fix and minor extentions Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant