FIX issue #29

magespecialist · Aug 17, 2017 · c8aa29d · c8aa29d
1 parent fe2d0b9
commit c8aa29d
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 2 deletions.
diff --git a/Model/Total/Quote/AbstractTotal.php b/Model/Total/Quote/AbstractTotal.php
@@ -20,19 +20,38 @@
 
 namespace MSP\CashOnDelivery\Model\Total\Quote;
 
+use Magento\Quote\Api\PaymentMethodManagementInterface;
 use Magento\Quote\Model\Quote\Address\Total\AbstractTotal as MageAbstractTotal;
-use Magento\Quote\Model\Quote\Address\Total;
 use Magento\Quote\Model\Quote;
 
 abstract class AbstractTotal extends MageAbstractTotal
 {
+    /**
+     * @var PaymentMethodManagementInterface
+     */
+    private $paymentMethodManagement;
+
+    public function __construct(PaymentMethodManagementInterface $paymentMethodManagement)
+    {
+        $this->paymentMethodManagement = $paymentMethodManagement;
+    }
+
     /**
      * Return true if can apply totals
      * @param Quote $quote
      * @return bool
      */
     protected function _canApplyTotal(Quote $quote)
     {
+        // FIX bug issue #29
+        if (!$quote->getId()) {
+            return false;
+        }
+        $paymentMethodsList = $this->paymentMethodManagement->getList($quote->getId());
+        if ((count($paymentMethodsList) == 1) && ($paymentMethodsList[0]->getCode() == 'msp_cashondelivery')) {
+            return true;
+        }
+
         return ($quote->getPayment()->getMethod() == 'msp_cashondelivery');
     }
 }
diff --git a/Model/Total/Quote/Cashondelivery.php b/Model/Total/Quote/Cashondelivery.php
@@ -21,6 +21,7 @@
 namespace MSP\CashOnDelivery\Model\Total\Quote;
 
 use Magento\Framework\Pricing\PriceCurrencyInterface;
+use Magento\Quote\Api\PaymentMethodManagementInterface;
 use Magento\Quote\Model\Quote\Address\Total;
 use Magento\Quote\Api\Data\ShippingAssignmentInterface;
 use Magento\Quote\Model\Quote;
@@ -33,9 +34,12 @@ class Cashondelivery extends AbstractTotal
     protected $priceCurrencyInterface;
 
     public function __construct(
+        PaymentMethodManagementInterface $paymentMethodManagement,
         PriceCurrencyInterface $priceCurrencyInterface,
         CashondeliveryInterface $cashOnDeliveryInterface
     ) {
+        parent::__construct($paymentMethodManagement);
+
         $this->cashOnDeliveryInterface = $cashOnDeliveryInterface;
         $this->priceCurrencyInterface = $priceCurrencyInterface;
         $this->setCode('msp_cashondelivery');

diff --git a/Model/Total/Quote/CashondeliveryTax.php b/Model/Total/Quote/CashondeliveryTax.php
@@ -21,6 +21,7 @@
 namespace MSP\CashOnDelivery\Model\Total\Quote;
 
 use Magento\Framework\Pricing\PriceCurrencyInterface;
+use Magento\Quote\Api\PaymentMethodManagementInterface;
 use Magento\Quote\Model\Quote\Address\Total;
 use Magento\Quote\Api\Data\ShippingAssignmentInterface;
 use Magento\Quote\Model\Quote;
@@ -33,9 +34,11 @@ class CashondeliveryTax extends AbstractTotal
     protected $priceCurrencyInterface;
 
     public function __construct(
+        PaymentMethodManagementInterface $paymentMethodManagement,
         PriceCurrencyInterface $priceCurrencyInterface,
         CashondeliveryInterface $cashOnDeliveryInterface
     ) {
+        parent::__construct($paymentMethodManagement);
         $this->cashOnDeliveryInterface = $cashOnDeliveryInterface;
         $this->priceCurrencyInterface = $priceCurrencyInterface;
     }

diff --git a/etc/module.xml b/etc/module.xml
@@ -21,7 +21,7 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="MSP_CashOnDelivery" setup_version="1.1.7">
+    <module name="MSP_CashOnDelivery" setup_version="1.1.8">
         <sequence>
             <module name="Magento_Sales" />
             <module name="Magento_Payment" />