-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RegExUtil.java #2348
Merged
VitaliyBoyko
merged 1 commit into
magento:5.4.0-develop
from
perfcom:alphaLeporis-theme-regex-support-dashes
Oct 20, 2024
Merged
Update RegExUtil.java #2348
VitaliyBoyko
merged 1 commit into
magento:5.4.0-develop
from
perfcom:alphaLeporis-theme-regex-support-dashes
Oct 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating theme regex to support dashes.
VitaliyBoyko
approved these changes
Oct 15, 2024
VitaliyBoyko
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LouisdeLooze thank you for your contribution.
Could you please check tests?
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
Oct 15, 2024
Hi @VitaliyBoyko
|
@LouisdeLooze thank you. Will check it. Could you please create a backport PR to the 5.3.1-develop branch? |
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating theme regex to support dashes.
Description (*)
According to the Magento devdocs:
The current regex limits the themes to:
The adapted regex allows the themes to be:
Thanks @sdouma for the regex!
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)