Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge issues from applying 2.4.7-p3 patch #111

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rhoerr
Copy link
Contributor

@rhoerr rhoerr commented Nov 1, 2024

Description (*)

This PR restores an erroneously deleted ValidateCustomerData class (from deletion of a different file of the same name) to correct test failures. It also corrects minor duplicated language strings and an indent difference.

Related Pull Requests

#107

Fixed Issues (if relevant)

  1. Fixes test failure https://github.com/mage-os/mageos-magento2/actions/runs/11584377285/job/32253330850

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@rhoerr rhoerr requested a review from a team as a code owner November 1, 2024 02:08
@rhoerr rhoerr merged commit c7fc5db into mage-os:release/1.x Nov 1, 2024
6 of 7 checks passed
@rhoerr rhoerr deleted the fix/2.4.7-p3-patch-differences branch November 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants