Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unstable-no-link feature #525

Closed
wants to merge 9 commits into from
Closed

Add unstable-no-link feature #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edb0422
Add link feature
xiaopengli89 Oct 18, 2023
0e1fbe1
change to no-link-* features
xiaopengli89 Oct 30, 2023
3e6c091
more frameworks
xiaopengli89 Oct 30, 2023
e75323a
clippy: allow negative feature names
xiaopengli89 Oct 30, 2023
137d72c
fix ci
xiaopengli89 Oct 30, 2023
c084f81
allow clippy::negative_feature_names
xiaopengli89 Nov 1, 2023
96b65d3
revert ci
xiaopengli89 Nov 1, 2023
de28257
fix clippy
xiaopengli89 Nov 1, 2023
b65ed2e
refactor to unstable-no-link feature
xiaopengli89 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/header-translator/src/library.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ impl fmt::Display for Library {
// FIXME: We always do cfg_attr(feature = "apple", ...) to make compiling things for GNUStep easier.
writeln!(
f,
"#[cfg_attr(feature = \"apple\", link(name = \"{}\", kind = \"framework\"))]",
"#[cfg_attr(all(feature = \"apple\", not(feature = \"unstable-no-link\")), link(name = \"{}\", kind = \"framework\"))]",
self.link_name
)?;
if let Some(gnustep_library) = &self.data.gnustep_library {
Expand Down
3 changes: 3 additions & 0 deletions crates/icrate/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ required-features = [
[features]
default = ["std", "apple"]

# Disable to link frameworks, which may not available on lower OS versions, or users don't want to load the frameworks at startup (dyld).
unstable-no-link = []

# Currently not possible to turn off, put here for forwards compatibility.
std = ["alloc", "objc2?/std", "block2?/std"]
alloc = ["objc2?/alloc", "block2?/alloc"]
Expand Down
Loading