Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: build.yaml would pass on the hash of madara bin to use (WIP) #362

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ jobs:
permissions:
pull-requests: write
runs-on: ubuntu-latest
outputs:
binary_hash: ${{ steps.binary_hash.outputs.hash }}

steps:
- uses: actions/checkout@v3
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,3 @@ jobs:
name: Build Madara
uses: ./.github/workflows/build.yml
needs: changelog

js_test:
name: Run JS Tests
uses: ./.github/workflows/starknet-js-test.yml
needs: build
13 changes: 10 additions & 3 deletions .github/workflows/starknet-js-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,28 @@ name: Starknet-js Compatibility Tests

on:
workflow_dispatch:
workflow_run:
workflows: ["build"]
types:
- completed
workflow_call:
inputs:
binary_hash:
required: true
type: string

jobs:
js-test:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- uses: actions/checkout@v3
- name: Restore Madara binary
uses: actions/cache@v3
id: cache-madara
with:
path: target/release/madara
key: ${{ runner.os }}-madara-bin-
restore-keys: |
${{ runner.os }}-madara-bin-
key: ${{ runner.os }}-madara-bin-${{ inputs.binary_hash }}
fail-on-cache-miss: true
- name: Restore Cairo build artifacts
uses: actions/cache@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next release

- refactor: starknet js workflow updated to take the right binary hash
- fix(rocksdb): update max open files opt
- code: refactor to use otel tracing instead of prometheus (removed mc-metrics, added mc-analytics)
- fix(version constants): 0.13.2 was mapped to wrong constants
Expand Down
Loading