Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devnet): devnet predeployed contracts stable address across systems (re) #346

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

cchudant
Copy link
Member

Pull Request type

  • Bugfix

#332 is wrong because of the docs of SmallRng says:

The algorithm is deterministic but should not be considered reproducible due to dependence on platform and possible replacement in future library versions.

Does this introduce a breaking change?

YES: all the predeployed contracts addresses are changed, once again :)

Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thankssss

@akhercha akhercha merged commit 57552e4 into main Oct 15, 2024
10 checks passed
@akhercha akhercha deleted the fix-devnet-predeployed-stable branch October 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants