fix: pathfinder block hash mismatch block 0 (sequencer mode) #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trantorian1
reviewed
Oct 15, 2024
jbcaron
approved these changes
Oct 15, 2024
1 task
antiyro
approved these changes
Oct 15, 2024
Trantorian1
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compute_hashmethod for state commitments was not sorting the storage entries. Maybe this wasn't caught because the feeder gateway always returns state diffs in a sorted order. I have fixed this and added a test case.The current code iterates over storage_diffs twice (once to sort storage entries and then to sort storage diffs as well). I feel this is cleaner compared to another alternative of writing custom logic for sorting which takes a mutable and also this doesn't have that much of an overhead. Happy to hear thoughts though!