Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): updated readme and fixed launcher #298

Merged
merged 32 commits into from
Oct 2, 2024
Merged

fix(docs): updated readme and fixed launcher #298

merged 32 commits into from
Oct 2, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented Oct 2, 2024

No description provided.

@antiyro antiyro added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 2, 2024
@antiyro antiyro self-assigned this Oct 2, 2024
@antiyro antiyro marked this pull request as ready for review October 2, 2024 12:43
Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Apoorv Sadana <[email protected]>
Comment on lines -56 to -57
VOLUME crates/primitives/chain_config/presets
VOLUME crates/primitives/chain_config/resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to mount this anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop this is unused and was added as a fix for unaccessible chain configs but now we fetch them (iirc)

@antiyro antiyro merged commit 6e69868 into main Oct 2, 2024
5 of 7 checks passed
@antiyro antiyro deleted the fix/high branch October 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants