Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : events from call info / UDC cairo 0 migration #263

Merged
merged 11 commits into from
Sep 23, 2024
Merged

fix : events from call info / UDC cairo 0 migration #263

merged 11 commits into from
Sep 23, 2024

Conversation

ocdbytes
Copy link
Member

@ocdbytes ocdbytes commented Sep 14, 2024 •
edited
Loading

  • Events emitting fix.
  • UDC migration to cairo 0. (to support starknet.js deploy function)

Pending :

  • need to add unit test cases.

@antiyro antiyro added bug Something isn't working enhancement New feature or request labels Sep 16, 2024
@Mohiiit Mohiiit marked this pull request as ready for review September 18, 2024 13:25
Trantorian1
Trantorian1 requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good, just please update your use of the log crate to refer to workspace dependencies.

crates/primitives/receipt/Cargo.toml Outdated
# Other
log = "0.4.21"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use workspace log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@Trantorian1 Trantorian1 merged commit 371b70b into main Sep 23, 2024
8 checks passed
@Trantorian1 Trantorian1 mentioned this pull request Oct 11, 2024
Merged
@cchudant cchudant mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohiiit Mohiiit Mohiiit left review comments

@EvolveArt EvolveArt EvolveArt approved these changes

@apoorvsadana apoorvsadana apoorvsadana approved these changes

@Trantorian1 Trantorian1 Trantorian1 approved these changes

Assignees

@ocdbytes ocdbytes

Labels
bug Something isn't working enhancement New feature or request
Projects
Madara
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ocdbytes @EvolveArt @Mohiiit @apoorvsadana @Trantorian1 @antiyro