Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l1): fixed l1 thread to reflect correct state_root, block_number, block_hash #14

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented Mar 12, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Resolves: #NA

What is the new behavior?

Does this introduce a breaking change?

Other information

Copy link
Member

@jbcaron jbcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arc in Lazy_static is not necessary, It's better to use an Option<> for ETHEREUM_STATE_UPDATE

Copy link
Contributor

@Tbelleng Tbelleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me, lfg

@antiyro antiyro merged commit 14a8412 into main Mar 12, 2024
6 checks passed
@antiyro antiyro deleted the fix/l1 branch March 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants