Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openh264: use -read_only_relocs suppress in LDFLAGS on macOS <=10.6 i386 #27461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Description

https://build.macports.org/builders/ports-10.6_i386-builder/builds/187131/steps/install-port/logs/stdio
I can't really test it, so any help would be appreciated.
OpenBSD ports use a similar flag for i386.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 4.2 4C199

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou changed the title openh264: use -read_only_relocs suppress in LDFLAGS on macOS <=10.6 i386 openh264: use -read_only_relocs suppress in LDFLAGS on macOS <=10.6 i386 Jan 22, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou marked this pull request as ready for review January 24, 2025 20:13
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@barracuda156 @fhgwright can test this code please?

@barracuda156
Copy link
Contributor

@aeiouaeiouaeiouaeiouaeiouaeiou I can’t test for i386, but the suggested fix looks safe, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants