Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk-m-220: New port #27443

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Dave-Allured
Copy link
Contributor

@Dave-Allured Dave-Allured commented Jan 21, 2025

Description

This is a temporary port for the current stable version of VTK-M. This is a very close clone of the original vtk-m port. The purpose is to support development of the vtk port.

This temporary port will be replaced when it becomes possible to update the main vtk-m port, now stuck at an earlier version because of a dependency issue. See #26789 for details.

Type(s)
  • enhancement
Tested on

Mac OS 14.6.1
Xcode 16.2
Command Line Tools 16.2.0

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tried a full install with sudo port -vs install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

.

* Temporary port to support VTK port development.
@reneeotten
Copy link
Contributor

if a newer version is added it should be as a subport in the original Portfile. Why can you not use the earlier version for whatever other port needs this? Is there really a need to be the "latest-and-greatest"?

@Dave-Allured
Copy link
Contributor Author

if a newer version is added it should be as a subport in the original Portfile. Why can you not use the earlier version for whatever other port needs this? Is there really a need to be the "latest-and-greatest"?

@reneeotten Here are my goals.

  1. Migrate the VTK port to use external dependencies, rather than bundled dependencies. VTK-M is by far the largest of those bundled dependencies, judging by source code size only.
  2. Test the VTK port with the most recent stable version of VTK-M, which is more recent than the current bundled version.
  3. Provide the latest stable version of VTK-M for general use, as a matter of policy.
  4. Experiment with removing bundled dependencies in VTK-M itself.
  5. Do not interfere in any way with the current VTK-M port, currently stuck at down-level 1.7.1 for reasons that we discussed in vtk-m: Update to 2.2.0 #26789.

From this I concluded that a separate experimental port for VTK-M was the best approach. Subports would reduce my ability to experiment. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants