Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftformat: new port #25542

Merged

Conversation

jrabinow
Copy link
Contributor

Description

Add new port: swiftformat

Type(s)
Tested on

macOS 14.6.1 23G93 arm64
Xcode 15.4 15F31d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick? Error: Using openmaintainer without any other maintainer who should I add
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install? -vs since trace mode is broken on arm64
  • tested basic functionality of all binary files?
  • [] checked that the Portfile's most important variants haven't been broken? N/A

@jrabinow jrabinow force-pushed the swissknife/submission/swiftformat branch from 40cb4f4 to 512cff9 Compare September 2, 2024 00:22
platforms {darwin >= 21}
categories devel
license MIT
maintainers {jrabinow @jrabinow} openmaintainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first entry here should be your (obfuscated) e-mail address; what you have now implies a [email protected] address which isn't correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I went and looked up the guide to make sure I got it right this time.

Judging by the output of rg maintainers|grep -v nomaintainer|grep -E '\{@[^ ]*\}', there aren't many ports without email, and so providing an email address is preferable. I'm wondering if it's nevertheless accepted to not provide an email address

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-github that was the only way - I don't know what the policy is now. I know we'd prefer a email, as we mostly discuss over mailing list.

@jrabinow jrabinow force-pushed the swissknife/submission/swiftformat branch from 512cff9 to 14e4820 Compare September 2, 2024 03:59
@markemer markemer requested a review from reneeotten September 3, 2024 15:44
@reneeotten reneeotten merged commit b6f1845 into macports:master Sep 4, 2024
3 checks passed
@jrabinow jrabinow deleted the swissknife/submission/swiftformat branch September 4, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants