Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngspice: fix the port for < 10.8 #25537

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Conversation

barracuda156
Copy link
Contributor

Description

Fixes ngspice after a breaking update, fixes what was broken in the earlier version.

@markemer @bpdegnan

P. S. Likely fixups which are for < 10.7 should be used unconditionally, but let maintainers decide on that.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@bpdegnan for port ngspice.
@markemer for port ngspice.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Aug 31, 2024
@barracuda156 barracuda156 changed the title Ngspice ngspice: fix the port for < 10.8 Aug 31, 2024

-AM_CFLAGS = -static
+# MacOS linker does not need this.
+# AM_CFLAGS = -static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a weird old leftover, ngspice goes all the way back to SPICE3 essentially.

@markemer
Copy link
Member

Aside from pulling out the other stuff we don't need, this looks good. Thanks @barracuda156. Your commitment to keeping new stuff running on old stuff running is pretty legendary.

@bpdegnan
Copy link
Contributor

I have a Pismo with 10.4 that I only use to write papers. I probably should check against that as a habit. @barracuda156 thanks for being on top of it and @markemer, thanks for fixing it up.

@markemer markemer merged commit f6293ac into macports:master Sep 2, 2024
3 checks passed
@barracuda156 barracuda156 deleted the ngspice branch September 3, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants