-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngspice: fix the port for < 10.8 #25537
Conversation
|
||
-AM_CFLAGS = -static | ||
+# MacOS linker does not need this. | ||
+# AM_CFLAGS = -static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a weird old leftover, ngspice goes all the way back to SPICE3 essentially.
Aside from pulling out the other stuff we don't need, this looks good. Thanks @barracuda156. Your commitment to keeping new stuff running on old stuff running is pretty legendary. |
I have a Pismo with 10.4 that I only use to write papers. I probably should check against that as a habit. @barracuda156 thanks for being on top of it and @markemer, thanks for fixing it up. |
Description
Fixes
ngspice
after a breaking update, fixes what was broken in the earlier version.@markemer @bpdegnan
P. S. Likely fixups which are for < 10.7 should be used unconditionally, but let maintainers decide on that.
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?