Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint: update to 0.57.0 #25522

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

herbygillot
Copy link
Member

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@csknns for port swiftlint.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Aug 30, 2024
devel/swiftlint/Portfile Outdated Show resolved Hide resolved
@markemer
Copy link
Member

error: 'swiftlint-0.57.0': package 'swiftlint-0.57.0' is using Swift tools version 5.9.0 but the installed version is 5.7.1

So this is just always gonna fail if Xcode < 15, so we need to add that to the Portfile. If you're using Swiftlint but don't have swift n or n-1, I'm not sure what exactly you're doing.

@markemer markemer changed the title swiftlint: update to 0.56.2 swiftlint: update to 0.57.0 Nov 3, 2024
@markemer markemer requested a review from reneeotten November 3, 2024 02:41
@reneeotten
Copy link
Contributor

@markemer I don't need to review this PR anyore; @herbygillot can merge/commit this himself whenever he feels it's ready.

@reneeotten reneeotten merged commit 3aff9d8 into macports:master Nov 21, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
Development

Successfully merging this pull request may close these issues.

4 participants