-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gajim: update to 1.9.3, update its python dependencies #25501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one request not even related to your OR but I noticed while reviewing.
net/gajim/Portfile
Outdated
path:lib/pkgconfig/gtk+-3.0.pc:gtk3 \ | ||
port:gtksourceview4 \ | ||
path:lib/pkgconfig/librsvg-2.0.pc:librsvg \ | ||
path:lib/pkgconfig/libsoup-2.4.pc:libsoup \ | ||
port:py${python.version}-certifi \ | ||
port:py${python.version}-css-parser \ | ||
port:py${python.version}-emoji \ | ||
port:py${python.version}-idna \ | ||
port:py${python.version}-keyring \ | ||
port:py${python.version}-nbxmpp \ | ||
port:py${python.version}-omemo-dr \ | ||
port:py${python.version}-pillow \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not your change but this should be "py-Pillow" to avoid breakage on case-sensitive file systems.
@reneeotten Fair enough, fixed. |
Description
Updates
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?