Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gajim: update to 1.9.3, update its python dependencies #25501

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

barracuda156
Copy link
Contributor

Description

Updates

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156 barracuda156 marked this pull request as draft August 28, 2024 14:21
@barracuda156 barracuda156 marked this pull request as ready for review August 28, 2024 17:56
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one request not even related to your OR but I noticed while reviewing.

path:lib/pkgconfig/gtk+-3.0.pc:gtk3 \
port:gtksourceview4 \
path:lib/pkgconfig/librsvg-2.0.pc:librsvg \
path:lib/pkgconfig/libsoup-2.4.pc:libsoup \
port:py${python.version}-certifi \
port:py${python.version}-css-parser \
port:py${python.version}-emoji \
port:py${python.version}-idna \
port:py${python.version}-keyring \
port:py${python.version}-nbxmpp \
port:py${python.version}-omemo-dr \
port:py${python.version}-pillow \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your change but this should be "py-Pillow" to avoid breakage on case-sensitive file systems.

@barracuda156
Copy link
Contributor Author

@reneeotten Fair enough, fixed.

@reneeotten reneeotten merged commit de46b42 into macports:master Aug 30, 2024
3 checks passed
@barracuda156 barracuda156 deleted the gajim branch August 30, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants