-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portindex: spoof compiler version #361
base: master
Are you sure you want to change the base?
Conversation
ec29f4b
to
4134d68
Compare
4134d68
to
253ef34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to do this all the time, but only in pretend mode. This is also only one factor that can affect the output. If we're going to go down this path, I'd like to see a general mechanism for overriding variables, with the policy of what to set them to left to the caller.
Currently the code is checking
What are some others?
Within the scope of this PR or in the future? Do you mean the caller should specify the compiler version? I refrained from that because the caller would have to have knowledge of which Xcode version is supported on which macOS version, and which compiler comes with that Xcode. |
The interposing proc is always added.
Potentially anything, which is why a general mechanism is needed. At least
Do it once, do it right.
"The caller" will in practice virtually always be |
Fixes: https://trac.macports.org/ticket/71755
Versions from https://gist.github.com/yamaya/2924292