Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct License metadata #50

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented Oct 4, 2024

Hi, while trying to package this project for Fedora, the question of the licensing of BIP39 came up. We have received confirmation that this is licensed under MIT1, and thus the recommendation I have received2 is that the License metadata should read MIT AND (MIT OR Apache-2.0), hence the PR.

Footnotes

  1. https://github.com/bitcoin/bips/pull/1395#issuecomment-2393930721

  2. https://bugzilla.redhat.com/show_bug.cgi?id=2297307

@maciejhirsz
Copy link
Owner

IANAL but wouldn't MIT OR (MIT AND Apache-2.0) be less redundant here?

@LecrisUT
Copy link
Author

LecrisUT commented Oct 4, 2024

Yes, both are equivalent. This form comunicates the reason for the license, i.e. part of it is MIT only, part of it is dual licensed. It also helps when packaging the leaf binary because all licenses are ANDed together from the dependencies and in this form we can eliminate some duplicates more easily.

@maciejhirsz maciejhirsz merged commit 07cf95d into maciejhirsz:master Oct 4, 2024
1 check passed
@LecrisUT LecrisUT deleted the patch-1 branch October 4, 2024 16:06
@maciejhirsz
Copy link
Owner

Published as 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants