Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLPathItem: Remove tool offset from calculation #297

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gb-g
Copy link

@gb-g gb-g commented Jun 8, 2021

Paths that have a tool offset are displayed wrong.
This PR displays them the same way as in AXIS.
Tested on LInux, on a lathe, with tool offset: Path display as in AXIS, and the tool offset is still used by the lathe machine itself.

Paths with tool offset are now displayed the same way as in AXIS.
@cerna
Copy link

cerna commented Jun 13, 2021

This pull request is in draft status intentionally and not by accident, right?

@gb-g gb-g force-pushed the paths-with-tool-offset branch 6 times, most recently from 2ad595f to 734af97 Compare June 14, 2021 00:36
@gb-g
Copy link
Author

gb-g commented Jun 14, 2021

Yes. Feedback is welcome, though!

@machinekoder
Copy link
Member

Interesting, if it works, this looks good. However, it indicates that the reported machine position is not absolute. Since this is the preview module only, I think it is okay, just worth mentioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants