Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup + optional case bits #27

Merged
merged 9 commits into from
Dec 30, 2019
Merged

Cleanup + optional case bits #27

merged 9 commits into from
Dec 30, 2019

Conversation

mach-kernel
Copy link
Owner

@mach-kernel mach-kernel commented Sep 29, 2019

Time has been scarce lately but I've been trying to make some progress. If anyone sees this and would like to lend an eye or two I'd greatly appreciate it as I don't write C every day (or frequently at all)

Things I am changing:

  • I had introduced this weird global for managing toggles when I could have just reused struct parameter, so I've removed struct globaltoggles and moved things to parameter.
  • Tried to fix all the warnings -- most of which appeared to be from implicit casts of char * to unsigned char * and vice versa. They're gone now and nothing seems broken. Famous last words!
  • Case bits can now be toggled via -C for ADDFILE, ADDFOLDER, and REPLACEFILE actions.

#14 #24 #25

@mach-kernel mach-kernel force-pushed the case-bits-optional branch 2 times, most recently from e3b4dc8 to 81a9442 Compare December 26, 2019 20:28
catalog uses name case for logging
for move operations, we detect to see if the case word is zero, since we
should not prompt for data we already know
@mach-kernel mach-kernel merged commit 67566c2 into master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant