Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M5CoreS3: simulate BtnA, BtnB and BtnC #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felmue
Copy link
Contributor

@felmue felmue commented Jul 4, 2024

by sacrificing 20 pixel at the bottom of the screen.

Notes:

  • disabled by default
  • can be enabled by defining M5CORES3_SIMULATE_BTNABC

by sacrificing 20 pixel at the bottom of the screen.

Notes:
- disabled by default
- can be enabled by defining M5CORES3_SIMULATE_BTNABC
@lovyan03
Copy link
Collaborator

Hello, @felmue

Sorry for keeping you waiting so long.
I recently updated the develop branch.
The bottom edge of the screen can now be used as a button area.

 M5.begin();

  // set by pixel.
  M5.setTouchButtonHeight(120);
// or
  // set by ratio (25 = 10% , 127 = 50% , 255 = 100%)
  M5.setTouchButtonHeightByRatio(128);

I plan to release this in the next update, but we'd love to hear your thoughts on it.

@felmue
Copy link
Contributor Author

felmue commented Jan 22, 2025

Hello @lovyan03

no worries.

I verified your changes with M5PaperS3 and M5CoreS3 and the three simulated buttons work great for me.

The only caveat I see is that the buttons do not follow the display rotation. But that is maybe not needed or even undesired. Not sure.

Thanks
Felix

@lovyan03
Copy link
Collaborator

We struggled a lot with whether or not to follow display rotation. In fact, one of the main reasons this feature was not implemented for so long was because we were unable to determine how to handle the issue.
However, in reality, many users are already using the product and are finding it inconvenient.
Taking too much time to make a decision would slow down the development speed of the M5 product, so we decided to provide something that would definitely improve the situation with a simple implementation, even if it had some limitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants