fix: reactivity

m3l1x · Sep 1, 2023 · 3d755c0 · 3d755c0
1 parent d158d61
commit 3d755c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/addon/modifiers/-private/ember-tabulator-init.js b/addon/modifiers/-private/ember-tabulator-init.js
@@ -14,15 +14,11 @@ export default class EmberTabulatorInitModifier extends Modifier {
   }
 
   modify(element, [options], { onUpdate }) {
-    if (!this.tabulator) {
-      this.tabulator = new Tabulator(element, {
-        reactiveData: true,
-        ...options,
-      });
-      options.events?.forEach((event) => {
-        this.tabulator.on(event.name, event.callback);
-      });
-      onUpdate?.(this.tabulator);
-    }
+    this.tabulator?.destroy();
+    this.tabulator = new Tabulator(element, options);
+    options.events?.forEach((event) => {
+      this.tabulator.on(event.name, event.callback);
+    });
+    onUpdate?.(this.tabulator);
   }
 }
diff --git a/addon/templates/components/ember-tabulator.hbs b/addon/templates/components/ember-tabulator.hbs
@@ -1,7 +1,6 @@
 <div
   class="ember-tabulator"
   ...attributes
-  {{did-update this.updateData @data}}
   {{-private/ember-tabulator-init this.args onUpdate=this.setInstance}}
 >
   {{#if (has-block)}}