Fix pyqt/sip4 compatibility issue #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing `sip4` and `ros2-pyqt5-sip-compat` deps with `python-pyqt5-sip4` as suggested in issue m2-farzan#9.
m2-farzan
added a commit
that referenced
this pull request
Feb 5, 2023
m2-farzan
added a commit
that referenced
this pull request
Feb 5, 2023
|
Testing: First attempt: https://github.com/m2-farzan/ros2-galactic-PKGBUILD/actions/runs/4095644618 |
|
@ruffson thanks for the lovely patch and sorry for the delay. The tests have failed but it's due to a problem with another AUR package. So despite the error, I've pushed this change to AUR. I'll port the patch to humble and rolling packages too. |
m2-farzan
added a commit
that referenced
this pull request
Feb 5, 2023
Of course! Thank you for all the work on this, it is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #9 by replacing
sip4andros2-pyqt5-sip-compatdeps withpython-pyqt5-sip4as suggested in the linked issue.Confirmed working on my machine when installing ros2-galactic (with paru).