Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVCON-6862] Execute terraform workflow from adhoc server mode #732

Merged
merged 43 commits into from
Apr 23, 2024

Conversation

smonero
Copy link
Contributor

@smonero smonero commented Mar 19, 2024

Just calls ExecuteWorkflow(). Plumbs the values needed from the globalCfg to the func ConstructAdhocExecParams. Also realized we don't actually need them in the config or server so I removed those instances.

relies on the other 2 PRs where we change things to use the pr number instead of the revision

@smonero smonero changed the title Execute terraform workflow from adhoc server mode [draft] Execute terraform workflow from adhoc server mode Mar 19, 2024
Copy link
Contributor

@samrabelachew samrabelachew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's break this up into separate PRs, one enabling the workflow, the other changing the mode name

@smonero
Copy link
Contributor Author

smonero commented Mar 20, 2024

Q's and answers:

  • Do we care about the result from manually executing the workflow? - no, that would only be if we wanted to interact with it during or after execution
  • Should it be in its own go routine? - yes
  • Should we reuse the root_config_builder from the gateway config? (We have our own config, but does that mean we should also have our own root_config_builder (we need this to get the atlantis root from) (we talked about making our own since we wanted to potentially improve the "double-clone" issue but not sure if that was concrete) - yes, we need our own, this can be a separate PR
  • Was thinking about breaking down this PR into 3 PRs: 1 to make a function that gets all the ghRepo values we need, 1 to make a function that makes the atlantisRoot we need, then a 3rd one that takes those and constructs the request that it then passes to the ExecuteWorkflow func. Thoughts? - ok

@smonero
Copy link
Contributor Author

smonero commented Mar 20, 2024

will rely on #735

@smonero smonero changed the title [draft] Execute terraform workflow from adhoc server mode Execute terraform workflow from adhoc server mode Mar 21, 2024
@smonero smonero changed the title Execute terraform workflow from adhoc server mode [DEVCON-6862] Execute terraform workflow from adhoc server mode Mar 22, 2024
@smonero smonero force-pushed the executeWorkflow1 branch 2 times, most recently from f595e57 to 357bae4 Compare April 10, 2024 20:15
@smonero
Copy link
Contributor Author

smonero commented Apr 12, 2024

now failing with [4/12/2024, 2:22:39 PM] building root cfgs: creating temporary clone at path: : failed to clone directory: running command in separate process group: waiting for process: exit status 128

@smonero
Copy link
Contributor Author

smonero commented Apr 14, 2024

ok fixed, now next issue is invalid file fetcher options

[4/14/2024, 12:12:04 PM] Atlantis started - listening on port 4141 [4/14/2024, 12:12:04 PM] Started Worker [4/14/2024, 12:12:05 PM] wrote git credentials to /root/.git-credentials [4/14/2024, 12:12:05 PM] successfully ran git config --global credential.helper store [4/14/2024, 12:12:05 PM] successfully ran git config --global url.https://[email protected] ssh://[email protected] [4/14/2024, 12:12:05 PM] building root cfgs: getting matching roots: finding modified files: []: invalid fileFetcherOptions

@smonero
Copy link
Contributor Author

smonero commented Apr 19, 2024

will remove all the logging tomorrow once we get the other prs merged and this tested

@smonero
Copy link
Contributor Author

smonero commented Apr 20, 2024

cool it works!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@smonero smonero merged commit 146af39 into main Apr 23, 2024
3 checks passed
@smonero smonero deleted the executeWorkflow1 branch April 23, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants