Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always update checkrun status for terraform workflows #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Always update checkrun status for terraform workflows #719

wants to merge 2 commits into from

Commits on Oct 10, 2023

  1. Always update checkrun status for terraform workflows 

    Why?
* Terraform workflows cannot cancel due to WaitForCancellation, so we might as well try to update the status of the checkrun.
* We also think this will help with the non determinism issues we are seeing where cancellations can occur at different than expected times on replay, causing the checkrun cache to be inaccurate, thus causing wrong calls to either create or update.
    @asubrocky
    asubrocky committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2bb529b View commit details
    Browse the repository at this point in the history

  2. add artificial sleep to "simple" root

    @asubrocky
    asubrocky committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8af0ee7 View commit details
    Browse the repository at this point in the history