Set up new gh ratelimit publisher for gateway/temporalworker #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrabelachew
changed the title
samrabelachew
commented
Jul 14, 2023
| "github.com/runatlantis/atlantis/server/neptune/sync" | ||
| "github.com/runatlantis/atlantis/server/vcs" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| const testRoot = "testroot" | ||
|
|
||
| type testAllocator struct { |
There was a problem hiding this comment.
Deleting this is an unrelated lint fix (not used code)
mikecutalo
reviewed
Jul 14, 2023
Comment on lines
+32
to
+35
| installationClient, err := r.ClientCreator.NewInstallationClient(r.InstallationID) | ||
| if err != nil { | ||
| return errors.Wrap(err, "creating installation client") | ||
| } |
There was a problem hiding this comment.
is this creating a new client every time? or does it pass back one thats already been created?
There was a problem hiding this comment.
ClientCreator comment:
// NewCachingClientCreator returns a ClientCreator that creates a GitHub client for installations of the app specified
// by the provided arguments. It uses an LRU cache of the provided capacity to store clients created for installations
// and returns cached clients when a cache hit exists.
See code itself for cache layer: https://github.com/palantir/go-githubapp/blob/develop/githubapp/caching_client_creator.go#L74
mikecutalo
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here: