check is legit

lyft · Sep 10, 2024 · 6794cb2 · 6794cb2
1 parent 3ac141d
commit 6794cb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/server/legacy/controllers/jobs_controller.go b/server/legacy/controllers/jobs_controller.go
@@ -41,7 +41,7 @@ func (j *JobsController) getProjectJobs(w http.ResponseWriter, r *http.Request)
 	jobID, err := j.KeyGenerator.Generate(r)
 
 	if err != nil {
-		j.respond(w, http.StatusBadRequest, err.Error())
+		j.respond(w, http.StatusBadRequest, "%s", err.Error())
 		return err
 	}
 
@@ -71,7 +71,7 @@ func (j *JobsController) getProjectJobsWS(w http.ResponseWriter, r *http.Request
 	err := j.WsMux.Handle(w, r)
 
 	if err != nil {
-		j.respond(w, http.StatusBadRequest, err.Error())
+		j.respond(w, http.StatusBadRequest, "%s", err.Error())
 		return err
 	}
 
@@ -90,8 +90,6 @@ func (j *JobsController) GetProjectJobsWS(w http.ResponseWriter, r *http.Request
 	}
 }
 
-// disabling govet linter for now as it has a bug as highlighted in https://github.com/argoproj/argo-cd/issues/19772 also
-// nolint: govet
 func (j *JobsController) respond(w http.ResponseWriter, responseCode int, format string, args ...interface{}) {
 	response := fmt.Sprintf(format, args...)
 	j.Logger.Error(response)

diff --git a/server/neptune/temporalworker/controllers/job_controller.go b/server/neptune/temporalworker/controllers/job_controller.go
@@ -78,7 +78,7 @@ func NewJobsController(
 func (j *JobsController) getProjectJobs(w http.ResponseWriter, r *http.Request) error {
 	jobID, err := j.KeyGenerator.Generate(r)
 	if err != nil {
-		j.respond(w, http.StatusBadRequest, err.Error())
+		j.respond(w, http.StatusBadRequest, "%s", err.Error())
 		return err
 	}
 
@@ -106,7 +106,7 @@ func (j *JobsController) GetProjectJobs(w http.ResponseWriter, r *http.Request)
 func (j *JobsController) getProjectJobsWS(w http.ResponseWriter, r *http.Request) error {
 	err := j.WsMux.Handle(w, r)
 	if err != nil {
-		j.respond(w, http.StatusBadRequest, err.Error())
+		j.respond(w, http.StatusBadRequest, "%s", err.Error())
 		return err
 	}
 	return nil