Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume meter #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Volume meter #98

wants to merge 2 commits into from

Conversation

palinek
Copy link
Contributor

@palinek palinek commented Oct 26, 2018

fixes #75

@tsujan
Copy link
Member

tsujan commented Oct 26, 2018

I don't think the animation saves a tangible amount of CPU time. Moreover, it seems much better to me when the value shown by the progressbar is that of the moment -- quick ups and downs are informative (although the animation is only for ups downs).

@palinek
Copy link
Contributor Author

palinek commented Oct 26, 2018

Moreover, it seems much better to me when the value shown by the progressbar is that of the moment

It is not so even in current master implementation:

    if (lastPeak >= DECAY_STEP)
        if (v < lastPeak - DECAY_STEP)
            v = lastPeak - DECAY_STEP;

@tsujan
Copy link
Member

tsujan commented Oct 26, 2018

It is not so even in current master implementation:

The current master is better. I first compiled, then saw that a piano concerto "looked" like a violin concerto (contrary to my installed pavucontrol-qt), and only then, saw the diff.

@RJVB
Copy link

RJVB commented Jul 30, 2024

I don't think the animation saves a tangible amount of CPU time.

AFAICT the pulseaudio daemon itself burns at least as much CPU as pavucontrol-qt when showing the VU meters.

This is the main reason why I rarely leave the application open, while I'd actually prefer that when changing audio devices ("sinks").

It would be useful to have the Show volume meters checkbox in a new frame under the tabbox widget, so it is accessible from all tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No volume meter with some Qt styles.
3 participants