Check for FolderModelItem info (and FmPath) #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a shot in the dark to prevent rare crashes (lxqt/pcmanfm-qt#397).
palinek
reviewed
Oct 3, 2016
| urilist.append(uri); | ||
| urilist.append('\n'); | ||
| g_free(uri); | ||
| if(item->info) { |
There was a problem hiding this comment.
How about condensing the conditional if (item && item->info) ?
There was a problem hiding this comment.
Yes, I know. I just wanted to emphasize that item->info may be null theoretically (I still don't know if that's possible in practice),
paulolieuthier
approved these changes
Oct 3, 2016
agaida
approved these changes
Oct 3, 2016
|
Merged into b577385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot in the dark to prevent rare crashes (lxqt/pcmanfm-qt#397).