Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brand URL generation #2065

Closed
wants to merge 2 commits into from
Closed

Fix Brand URL generation #2065

wants to merge 2 commits into from

Conversation

allantatter
Copy link

Fix Brand URL generation according to the discussion in Discord #general.

Simplify the URL generation process by prioritizing the model's name 
when creating URLs. Remove redundant checks and improve code 
readability by standardizing spacing in concatenation operations. 
These changes enhance maintainability and ensure consistent 
formatting throughout the UrlGenerator class.
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 2:29pm

Copy link

Thanks for submitting a PR!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. If your fork belongs to a GitHub organization, please move the repository to your personal account and try again. If you're already using a personal fork, you can learn how to enable maintainer access in the GitHub documentation.

@allantatter
Copy link
Author

I see my editor also changed some formatting. If you know how configure the editor to fit into your preferred way of formatting, let me know.

@alecritson
Copy link
Collaborator

@allantatter Looks like this was closed due to the core team not having access. Could you try fix the issue and either re open or create a new PR, thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants