-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotfiles #1349
Update dotfiles #1349
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@adevade Should this PR be ready for review? |
@glennjacobs Sorry, I got busy 😅 I was wondering if maybe the dotfiles in the separate packages should be updated as well? I'm not too familiar with how the splitting of the mono-repo works... |
Generally speaking, when developing you do so on the monorepo, so we may not even need them in each package. |
Okay, so development files like If someone is |
Yes true. It will be different in v1.0, but for now I agree. |
I think this is looking good. Let me know when it's ready for review. |
I think this is ready to be reviewed! Should it still target the 0.7 branch? |
Would it be OK to target |
Changed branch to |
References:
https://github.com/laravel/framework/blob/10.x/.gitattributes
https://github.com/laravel/laravel/blob/10.x/.gitattributes
https://github.com/livewire/livewire/blob/main/.gitattributes
https://github.com/filamentphp/filament/blob/3.x/.gitattributes