Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotfiles #1349

Merged
merged 21 commits into from
Jan 15, 2024
Merged

Update dotfiles #1349

merged 21 commits into from
Jan 15, 2024

Conversation

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 1:56pm

@glennjacobs
Copy link
Contributor

@adevade Should this PR be ready for review?

@adevade
Copy link
Contributor Author

adevade commented Dec 19, 2023

@glennjacobs Sorry, I got busy 😅

I was wondering if maybe the dotfiles in the separate packages should be updated as well? I'm not too familiar with how the splitting of the mono-repo works...

@glennjacobs
Copy link
Contributor

@glennjacobs Sorry, I got busy 😅

I was wondering if maybe the dotfiles in the separate packages should be updated as well? I'm not too familiar with how the splitting of the mono-repo works...

Generally speaking, when developing you do so on the monorepo, so we may not even need them in each package.

@adevade
Copy link
Contributor Author

adevade commented Dec 19, 2023

Okay, so development files like .editorconfig is not needed in those folder. But files like .gitattributes should still be updated I think.

If someone is composer require-ing just the core package, then stuff like the .github folder and the tests would not have to be pulled down to their app.

@glennjacobs
Copy link
Contributor

Okay, so development files like .editorconfig is not needed in those folder. But files like .gitattributes should still be updated I think.

If someone is composer require-ing just the core package, then stuff like the .github folder and the tests would not have to be pulled down to their app.

Yes true. It will be different in v1.0, but for now I agree.

@glennjacobs
Copy link
Contributor

I think this is looking good. Let me know when it's ready for review.

@adevade adevade marked this pull request as ready for review December 19, 2023 09:50
@adevade
Copy link
Contributor Author

adevade commented Dec 20, 2023

I think this is ready to be reviewed! Should it still target the 0.7 branch?

@glennjacobs
Copy link
Contributor

I think this is ready to be reviewed! Should it still target the 0.7 branch?

Would it be OK to target 0.8 please?

@glennjacobs glennjacobs added this to the v0.8 milestone Dec 22, 2023
@adevade adevade changed the base branch from 0.7 to 0.8 December 22, 2023 13:26
@adevade
Copy link
Contributor Author

adevade commented Dec 22, 2023

Changed branch to 0.8 and pulled in latest changes 👍

@alecritson alecritson merged commit ad25097 into lunarphp:0.8 Jan 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants