Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Commit

Permalink
The lost explorer v4.2.3
Browse files Browse the repository at this point in the history
  • Loading branch information
luckylooke committed Aug 30, 2016
1 parent c4d987b commit 037e303
Show file tree
Hide file tree
Showing 13 changed files with 37 additions and 34 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dragular",
"version": "4.2.2",
"version": "4.2.3",
"description": "Angular drag and drop library based on dragula, but full featured. For light-weight angular wrap of dragula look for angular-dragula",
"main": [
"dist/dragular.min.js",
Expand Down
3 changes: 3 additions & 0 deletions changelog.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
- **[Braking change!]** rename 'dragulardrag' event to 'dragulardragstart'
- new event 'dragulardrag' emited each iteration while dragging

# 4.2.3 The lost explorer
- fixed #107 - IE dragging issue, drag did not start

# 4.2.2 The Drop
- fixed #104 - drop index undefined in dragulardrop event listeners

Expand Down
6 changes: 3 additions & 3 deletions dist/dragular.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ return /******/ (function(modules) { // webpackBootstrap
var dragularService = __webpack_require__(2);

/**
* Dragular 4.2.2 by Luckylooke https://github.com/luckylooke/dragular
* Dragular 4.2.3 by Luckylooke https://github.com/luckylooke/dragular
* Angular version of dragula https://github.com/bevacqua/dragula
*/
module.exports = 'dragularModule';
Expand Down Expand Up @@ -1148,10 +1148,10 @@ return /******/ (function(modules) { // webpackBootstrap
function whichMouseButton (e) {
if (e.touches) { return e.touches.length; }
if (e.originalEvent && e.originalEvent.touches) { return e.originalEvent.touches.length; }
if (e.which !== void 0 && e.which !== 0) { return e.which; } // github.com/bevacqua/dragula/issues/261
if (e.buttons !== undefined) { return e.buttons; }
if (e.which !== undefined) { return e.which; }
var button = e.button;
if (button !== undefined) { // see https://github.com/jquery/jquery/blob/99e8ff1baa7ae341e94bb89c3e84570c7c3ad9ea/src/event.js#L573-L575
if (button !== undefined) { // see github.com/jquery/jquery/blob/99e8ff1baa7ae341e94bb89c3e84570c7c3ad9ea/src/event.js#L573-L575
return button & 1 ? 1 : button & 2 ? 3 : (button & 4 ? 2 : 0);
}
}
Expand Down
2 changes: 1 addition & 1 deletion dist/dragular.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/dragular.min.js.map

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions docs/dist/examples.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions docs/dist/examples.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/dist/examples.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/src/examples/partials/partial-home.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h1>DRAGULAR</h1>
<p>Browser support includes every sane browser and **IE7+**. <sub>_(Granted you polyfill the functional `Array` methods in ES5)_</sub></p>
<h2>Inspiration</h2>
<p>I am working on huge angular project and I am using several drag&drop libraries in it, one for UI, one for lists, etc.. I want to use one full-featured drag&drop library for whole project. As I could not find any suitable, I decided to create one. I have choosen great library <a href="http://github.com/bevacqua/dragula">dragula</a> by <a href="https://github.com/bevacqua">Nicolas Bevacqua</a> as my starting point, make it more angular and started to put features in it! If you wish light-weight angular version of dragula, there is <a href="http://github.com/bevacqua/angular-dragula">official angular version of dragula</a>.</p>
<p><b>Actual version 4.2.2 is based on dragula 3.6.3 and tested with angular 1.5.5.</b></p>
<p><b>Actual version 4.2.3 is based on dragula 3.6.3 and tested with angular 1.5.5.</b></p>
<h2>Differences of dragular (against dragula)</h2>
<ul>
<li>replaced dragula crossvent with angulars event binding</li>
Expand Down
16 changes: 8 additions & 8 deletions docs/src/examples/templates.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion readme.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Browser support includes every sane browser and **IE7+**. <sub>_(Granted you pol

I am working on huge angular project and I am using several drag&drop libraries in it, one for UI, one for lists, etc.. I want to use one full-featured drag&drop library for whole project. As I could not find any suitable, I decided to create one. I have choosen great library [dragula](http://github.com/bevacqua/dragula) by [Nicolas Bevacqua](http://github.com/bevacqua) as my starting point, make it more angular and started to put features in it! If you wish light-weight angular version of dragula, there is [official angular version of dragula](http://github.com/bevacqua/angular-dragula).

<b>Actual version 4.2.2 is based on dragula 3.6.3 and tested with angular 1.5.5.</b>
<b>Actual version 4.2.3 is based on dragula 3.6.3 and tested with angular 1.5.5.</b>

# Differences of dragular (against dragula)

Expand Down
2 changes: 1 addition & 1 deletion src/dragularModule.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var dragularDirective = require('./dragularDirective');
var dragularService = require('./dragularService');

/**
* Dragular 4.2.2 by Luckylooke https://github.com/luckylooke/dragular
* Dragular 4.2.3 by Luckylooke https://github.com/luckylooke/dragular
* Angular version of dragula https://github.com/bevacqua/dragula
*/
module.exports = 'dragularModule';
Expand Down
4 changes: 2 additions & 2 deletions src/dragularService.js
Original file line number Diff line number Diff line change
Expand Up @@ -1008,10 +1008,10 @@ var dragularService = function ($rootScope, $compile) {
function whichMouseButton (e) {
if (e.touches) { return e.touches.length; }
if (e.originalEvent && e.originalEvent.touches) { return e.originalEvent.touches.length; }
if (e.which !== void 0 && e.which !== 0) { return e.which; } // github.com/bevacqua/dragula/issues/261
if (e.buttons !== undefined) { return e.buttons; }
if (e.which !== undefined) { return e.which; }
var button = e.button;
if (button !== undefined) { // see https://github.com/jquery/jquery/blob/99e8ff1baa7ae341e94bb89c3e84570c7c3ad9ea/src/event.js#L573-L575
if (button !== undefined) { // see github.com/jquery/jquery/blob/99e8ff1baa7ae341e94bb89c3e84570c7c3ad9ea/src/event.js#L573-L575
return button & 1 ? 1 : button & 2 ? 3 : (button & 4 ? 2 : 0);
}
}
Expand Down

1 comment on commit 037e303

@luckylooke
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #107

Please sign in to comment.