Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validate_numeric args #1392

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Update validate_numeric args #1392

merged 1 commit into from
Oct 5, 2024

Conversation

snadon
Copy link
Contributor

@snadon snadon commented Oct 5, 2024

Fixes for #1081

jwoertink
jwoertink approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I kept putting this off because there was a plan to change the arg names again, but no clue when I'll ever get to that so we might as well have this correct for now and worry about a change later. 😅

@jwoertink jwoertink merged commit b8a325d into luckyframework:main Oct 5, 2024
2 checks passed
@jwoertink jwoertink added the hacktoberfest-accepted PRs accepted for Hacktoberfest label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snadon @jwoertink