Lucky env predicates #13
Conversation
src/lucky_env.cr
Outdated
| @@ -23,4 +23,18 @@ module LuckyEnv | |||
| load(file_path) | |||
| end | |||
| end | |||
|
|
|||
| def self.name | |||
There was a problem hiding this comment.
I don't particularly like calling it name when it's on the shard namespace, but couldn't really think of anything better. I think name was fine, when it was nested under Lucky::Env though.
If anyone have a suggestion, I'd love to hear it. 🙂
There was a problem hiding this comment.
Sounds good. I addressed this in 6ad252b. 🙂
There was a problem hiding this comment.
This is great! I agree with the name method comment. It was fine when in the Lucky app under Lucky::Env, but being in the shard might be a little more confusing. Maybe something like .environment might be more clear?
@paulcsmith what are your thoughts on this?
src/lucky_env.cr
Outdated
| @@ -23,4 +23,18 @@ module LuckyEnv | |||
| load(file_path) | |||
| end | |||
| end | |||
|
|
|||
| def self.name | |||
src/lucky_env.cr
Outdated
| ENV.fetch("LUCKY_ENV", "development") | ||
| end | ||
|
|
||
| {% for env in %w[development test production] %} |
There was a problem hiding this comment.
Can you add staging to this? I think that will cover the 99% use case, then later on we can figure out a nice way to make it more configurable at compile-time.
There was a problem hiding this comment.
@jwoertink I can, but we don't seem to include it by default right now, so I chose not to. However, I just added 6ad252b which makes it easier to extend LuckyEnv with custom environments. So instead of hardcoding a list within LuckyEnv itself, we can now just call LuckyEnv.add_env :staging to add this environment as well.
| private def with_env(key, value, &block) | ||
| original_value = ENV[key]? | ||
| ENV[key] = value | ||
| block.call | ||
| ensure | ||
| ENV[key] = original_value |
This will make it easier to extend LuckyEnv with custom environments.
| macro add_env(name) | ||
| def LuckyEnv.{{ name.id }}? | ||
| environment == {{ name.id.stringify }} | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Oh nice! Ok, this is awesome. This means in a generated app, we can have the config/env.cr file be some comments on how to use this to configure additional envs plus document using these methods 🥳 Good call ❤️
|
Thanks for adding this in! I've opened up luckyframework/lucky_cli#654 to address what the generated apps should do now. |
This PR addresses parts of #4 by moving the
Lucky::Envcode into lucky_env itself.