Update to latest Carbon. Added support for attachments. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Apr 19, 2024
| @@ -35,7 +36,6 @@ class Carbon::SendGridAdapter < Carbon::Adapter | |||
| end | |||
|
|
|||
| # :nodoc: | |||
| # Used only for testing | |||
There was a problem hiding this comment.
I'm not sure why this said used only for testing 🤔 This method is how we send the email lol
jwoertink
commented
Apr 19, 2024
| @@ -1,6 +1,7 @@ | |||
| require "http" | |||
| require "json" | |||
| require "carbon" | |||
| require "base64" | |||
There was a problem hiding this comment.
The Sendgrid API docs mention that attachments should be Base64.
jwoertink
commented
Apr 19, 2024
| files = [] of Hash(String, String) | ||
| email.attachments.map do |attachment| | ||
| case attachment | ||
| in AttachFile, ResourceFile |
There was a problem hiding this comment.
I don't know what the difference between AttachFile and ResourceFile are, but I'm guessing it's related to SMTP and doesn't really matter in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13
Now that Carbon has some support for attachments I need to update this shard so we can do a release. I followed the SMTP update for attachment and used the Sendgrid docs https://docs.sendgrid.com/api-reference/mail-send/mail-send to mimic the structure.