Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add Grafana dashboard for Grafana Operator #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ruben-rodriguez
Copy link
Contributor

@ruben-rodriguez ruben-rodriguez commented Oct 24, 2022

  • This PR adds Grafana Operator resources required to install the included Grafana dashboard.
  • It adds a symlink to the dashboard file from the dashboards folder inside the helm chart folder.
  • It allows to configure the Grafana selector label configured for the operator to pick up the CRDs.
  • This PR includes the changes in Helm: add additional labels to resources #55 in a separate merge commit (it can be cherry picked)
    Feel free to discard the PR if it doesn't make sense 😄

@lucky-sideburn
Copy link
Owner

Hi @ruben-rodriguez! Please let me know if I undestood correctly. In case you use prometheus stack with the Grafana Operator, with this code, the dashboard is automatically added to Grafana. Is it correct? Thanks!

@ruben-rodriguez
Copy link
Contributor Author

ruben-rodriguez commented Oct 25, 2022

Hi! Yes, exactly!

Basically, when you want to install a new Dashboard leveraging the Grafana Operator you create a GrafanaDashboard CRD (with the special label configured in the operator to pickup resources dashboardLabelSelector) pointing to a ConfigMap that includes the json spec: https://github.com/grafana-operator/grafana-operator/blob/master/documentation/api.md#grafanadashboard

Anyways, it might not make sense to merge it as not everyone uses Grafana Operator, and for those who do, it's easy to use this helm chart as dependency and just add the required templates for creating the additional resources required.

P.S: Thanks for your work! We are having a lot of fun playing our chaos experiments at work!

@lucky-sideburn
Copy link
Owner

Hi @ruben-rodriguez I will try it! Thank you for your feedback. I recently added a new feature "programming mode" for use yaml as a kind of Chaos Engineering programming.. There is also the following feature in doin for a web tail!
Screenshot 2022-10-25 at 11 49 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants