Add a replacement for MinecraftArgumentTypes #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original MinecraftArgumentTypes required too much maintenance and reflection to work across all versions, it was removed in commodore 2.0. Unfortunately, my command library Lamp depended on it internally to provide support for entity selectors.
I've written a simple enum that constructs ArgumentTypes as needed. It does not hook into the registry or look up ArgumentTypes by their names internally. All it does is construct them, optionally with arguments.
Tested on Minecraft 1.13.2, 1.16.5, 1.17, and 1.19.
You may want to remove the MinecraftArgumentTypes.ensureSetup() call in CommodoreProvider. I didn't know whether to add it or not, so I added it anyway