Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a replacement for MinecraftArgumentTypes #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Revxrsal
Copy link

@Revxrsal Revxrsal commented Jun 16, 2022

Since the original MinecraftArgumentTypes required too much maintenance and reflection to work across all versions, it was removed in commodore 2.0. Unfortunately, my command library Lamp depended on it internally to provide support for entity selectors.

I've written a simple enum that constructs ArgumentTypes as needed. It does not hook into the registry or look up ArgumentTypes by their names internally. All it does is construct them, optionally with arguments.

Tested on Minecraft 1.13.2, 1.16.5, 1.17, and 1.19.

You may want to remove the MinecraftArgumentTypes.ensureSetup() call in CommodoreProvider. I didn't know whether to add it or not, so I added it anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant