Make warnings fatal

admin/app/Application.scala

@@ -1,6 +1,5 @@
 package com.lucidchart.piezo.admin
 
-import com.lucidchart.piezo.util.DummyClassGenerator
 import com.softwaremill.macwire._
 import play.api.ApplicationLoader.Context
 import play.api._
@@ -12,7 +11,7 @@ import play.api.Mode
 import play.api.routing.Router
 import router.Routes
 import scala.concurrent.Future
-import com.lucidchart.piezo.admin.models._
+import scala.annotation.nowarn
 import com.lucidchart.piezo.admin.controllers._
 import com.lucidchart.piezo.WorkerSchedulerFactory
 import _root_.controllers.AssetsComponents
@@ -38,7 +37,7 @@ class PiezoAdminComponents(context: Context) extends BuiltInComponentsFromContex
   override val httpFilters: Seq[EssentialFilter] = {
     val ec = controllerComponents.executionContext
     Seq(
-      wire[RequestStatCollector]
+      new RequestStatCollector(ec)
     )
   }
   val logger = Logger("com.lucidchart.piezo.Global")
@@ -72,6 +71,7 @@ class PiezoAdminComponents(context: Context) extends BuiltInComponentsFromContex
 
   lazy val router: Router = {
     // add the prefix string in local scope for the Routes constructor
+    @nowarn
     val prefix: String = "/"
     wire[Routes]
   }

admin/app/com/lucidchart/piezo/admin/controllers/ApplicationController.scala

@@ -1,6 +1,5 @@
 package com.lucidchart.piezo.admin.controllers
 
-import play.api._
 import play.api.mvc._
 
 class ApplicationController(cc: ControllerComponents) extends AbstractController(cc) {

admin/app/com/lucidchart/piezo/admin/controllers/HealthCheck.scala

@@ -19,7 +19,7 @@ class HealthCheck(configuration: Configuration, cc: ControllerComponents) extend
     5
   }
 
-  def main = cc.actionBuilder { implicit requests=>
+  def main = cc.actionBuilder { request =>
     val workerHealth = areWorkersHealthy()
     val responseBody = Json.toJson(Map("HeartbeatTime" -> Json.toJson(workerHealth._2)))
     if(workerHealth._1) {

admin/app/com/lucidchart/piezo/admin/controllers/JobDataHelper.scala

@@ -2,7 +2,6 @@ package com.lucidchart.piezo.admin.controllers
 
 import org.quartz.JobDataMap
 import play.api.libs.json._
-import play.api.data.Form
 import play.api.data.Forms._
 
 case class DataMap(key: String, value: String)

admin/app/com/lucidchart/piezo/admin/controllers/JobFormHelper.scala

@@ -1,7 +1,6 @@
 package com.lucidchart.piezo.admin.controllers
 
 import org.quartz._
-import play.api.Logger
 import play.api.data.Form
 import play.api.data.Forms._
 import com.lucidchart.piezo.GeneratorClassLoader

admin/app/com/lucidchart/piezo/admin/controllers/Jobs.scala

@@ -7,7 +7,6 @@ import com.lucidchart.piezo.{JobHistoryModel, TriggerHistoryModel, TriggerMonito
 import org.quartz._
 import org.quartz.impl.matchers.GroupMatcher
 import play.api._
-import play.api.libs.functional.syntax._
 import play.api.libs.json._
 import play.api.mvc._
 import scala.jdk.CollectionConverters._
@@ -306,15 +305,15 @@ class Jobs(schedulerFactory: WorkerSchedulerFactory, jobView: html.job, cc: Cont
     )
   }
 
-  def jobGroupTypeAhead(sofar: String) = Action { implicit request =>
+  def jobGroupTypeAhead(sofar: String) = Action { request =>
     val groups = scheduler.getJobGroupNames().asScala.toList
 
     Ok(Json.obj("groups" -> groups.filter{ group =>
       group.toLowerCase.contains(sofar.toLowerCase)
     }))
   }
 
-  def jobNameTypeAhead(group: String, sofar: String) = Action { implicit request =>
+  def jobNameTypeAhead(group: String, sofar: String) = Action { request =>
     val jobs = scheduler.getJobKeys(GroupMatcher.jobGroupEquals(group)).asScala.toSet
 
     Ok(Json.obj("jobs" -> jobs.filter(_.getName.toLowerCase.contains(sofar.toLowerCase)).map(_.getName)))

admin/app/com/lucidchart/piezo/admin/controllers/TriggerFormHelper.scala

@@ -7,6 +7,7 @@ import org.quartz._
 import play.api.data.Form
 import play.api.data.Forms._
 import play.api.data.validation.{Constraint, Invalid, Valid, ValidationError}
+import scala.language.existentials
 
 class TriggerFormHelper(scheduler: Scheduler) extends JobDataHelper {
 
@@ -72,7 +73,7 @@ class TriggerFormHelper(scheduler: Scheduler) extends JobDataHelper {
       )
     ] = {
     val trigger = tp._1
-    val (triggerType: String, simple, cron) = trigger match {
+    val (triggerType: String, simple, cron) = (trigger: @unchecked) match {
       case cron: CronTrigger => ("cron", None, Some(cron.getScheduleBuilder))
       case simple: SimpleTrigger => ("simple", Some(simple.getScheduleBuilder), None)
     }

admin/app/com/lucidchart/piezo/admin/controllers/Triggers.scala

@@ -5,15 +5,12 @@ import java.util.Date
 import org.quartz.Trigger.TriggerState
 import org.quartz._
 import org.quartz.impl.triggers.{CronTriggerImpl, SimpleTriggerImpl}
-import play.api._
 import play.api.libs.json._
 import play.api.mvc._
-import com.lucidchart.piezo.admin.models._
 import scala.collection.mutable
 import scala.jdk.CollectionConverters._
 import scala.util.Try
 import play.api.Logging
-import play.api.i18n.I18nSupport
 
 class Triggers(schedulerFactory: WorkerSchedulerFactory, cc: ControllerComponents) extends AbstractController(cc) with Logging with ErrorLogging with play.api.i18n.I18nSupport {
 
@@ -293,15 +290,15 @@ class Triggers(schedulerFactory: WorkerSchedulerFactory, cc: ControllerComponent
     )
   }
 
-  def triggerGroupTypeAhead(sofar: String) = Action { implicit request =>
+  def triggerGroupTypeAhead(sofar: String) = Action { request =>
     val groups = scheduler.getTriggerGroupNames().asScala.toList
 
     Ok(Json.obj("groups" -> groups.filter{ group =>
       group.toLowerCase.contains(sofar.toLowerCase)
     }))
   }
 
-  def triggerJob(group: String, name: String) = Action { implicit request =>
+  def triggerJob(group: String, name: String) = Action { request =>
     val jobKey = new JobKey(name, group)
 
     if (scheduler.checkExists(jobKey)) {

admin/app/com/lucidchart/piezo/admin/utils/JobDetailHelper.scala

@@ -1,7 +1,6 @@
 package com.lucidchart.piezo.admin.utils
 import play.api.libs.json._
 import org.quartz._
-import scala.collection.JavaConverters._
 import com.lucidchart.piezo.admin.controllers.{JobFormHelper, JobDataHelper, TriggerHelper}
 import com.lucidchart.piezo.TriggerMonitoringModel
 

admin/app/com/lucidchart/piezo/admin/views/editJob.scala.html

@@ -12,9 +12,6 @@
 messagesProvider: play.api.i18n.MessagesProvider
 )
 
-@import com.lucidchart.piezo.admin.controllers.{routes=>piezoRoutes}
-@import com.lucidchart.piezo.admin.views
-@import org.quartz._
 @import com.lucidchart.piezo.admin.views.FormHelpers._
 
 @com.lucidchart.piezo.admin.views.html.jobsLayout(jobsByGroup, None, scripts) {

admin/app/com/lucidchart/piezo/admin/views/editTrigger.scala.html

@@ -14,9 +14,6 @@
 
 @import com.lucidchart.piezo.TriggerMonitoringPriority
 @import com.lucidchart.piezo.admin.controllers.{routes=>piezoRoutes}
-@import com.lucidchart.piezo.admin.views
-@import java.net.URLEncoder
-@import org.quartz._
 @import com.lucidchart.piezo.admin.views.FormHelpers._
 
 @com.lucidchart.piezo.admin.views.html.triggersLayout(triggersByGroup, None, scripts) {

admin/app/com/lucidchart/piezo/admin/views/errors/error.scala.html

@@ -4,11 +4,10 @@
 implicit
 request: RequestHeader
 )
-@import com.lucidchart.piezo.admin.views
 
 @com.lucidchart.piezo.admin.views.html.main("Piezo Error") {
   <div>
     <h1 class="text-danger">Error</h1>
     <p class="large">@errorMessage.getOrElse("Unknown Error")</p>
   </div>
-}
+}

admin/app/com/lucidchart/piezo/admin/views/errors/notfound.scala.html

@@ -4,11 +4,10 @@
 implicit
 request: RequestHeader
 )
-@import com.lucidchart.piezo.admin.views
 
 @com.lucidchart.piezo.admin.views.html.main("Piezo Error") {
 <div>
   <h1 class="text-danger">Page Not Found</h1>
   <p class="large">@message.getOrElse("The page you requested could not be located.")</p>
 </div>
-}
+}

admin/app/com/lucidchart/piezo/admin/views/index.scala.html

@@ -3,8 +3,6 @@
 implicit
 request: play.api.mvc.Request[AnyContent]
 )
-@import com.lucidchart.piezo.admin.controllers.{routes=>piezoRoutes}
-@import com.lucidchart.piezo.admin.views
 
 @com.lucidchart.piezo.admin.views.html.main("Piezo Admin Home") {
 <div class="clearfix" style="text-align: center; margin: 15px 0;">

admin/app/com/lucidchart/piezo/admin/views/job.scala.html

@@ -1,7 +1,5 @@
 @import com.lucidchart.piezo.admin.controllers.{routes=>piezoRoutes}
-@import com.lucidchart.piezo.admin.views
 @import play.api.Configuration
-@import java.net.URLEncoder
 @import org.quartz.TriggerKey
 @this(configuration: Configuration)
 

admin/app/com/lucidchart/piezo/admin/views/jobs.scala.html

@@ -1,6 +1,4 @@
 @import com.lucidchart.piezo.admin.controllers.{routes=>piezoRoutes}
-@import com.lucidchart.piezo.admin.views
-@import java.net.URLEncoder
 @import org.joda.time.format.DateTimeFormat
 @import org.joda.time.DateTime
 @import org.quartz.{JobKey, SchedulerMetaData}

admin/app/com/lucidchart/piezo/admin/views/trigger.scala.html

@@ -24,7 +24,7 @@ <h3 class="text-danger">@errorMessage.get</h3>
     @if(!currentTrigger.isEmpty) {
         <h3 class="pull-left">@currentTrigger.get.getKey.getGroup() &raquo; <span class="text-info">@currentTrigger.get.getKey.getName()</span></h3>
         <a class="piezo-button pull-right" data-toggle="tooltip" title="Duplicate trigger" href="@{piezoRoutes.Triggers.getNewTriggerForm(
-            currentTrigger.get match {
+            (currentTrigger.get: @unchecked) match {
                 case c: CronTrigger => "cron"
                 case s: SimpleTrigger => "simple"
             }

admin/build.sbt

@@ -17,6 +17,11 @@ libraryDependencies ++= Seq(
    specs2 % Test
 )
 
+scalacOptions ++= Seq(
+    "-Wconf:cat=unused-imports&src=(routes|twirl)/.*:info-summary",
+    "-Wconf:cat=other-match-analysis&src=routes/.*:silent",
+)
+
 maintainer := "Lucid Software Team <[email protected]>"
 
 name := "piezo-admin"

build.sbt

@@ -24,6 +24,12 @@ inThisBuild(Seq(
   scmInfo := Some(ScmInfo(url("https://github.com/lucidsoftware/piezo"), "scm:git:[email protected]:lucidsoftware/piezo.git")),
   version := sys.props.getOrElse("build.version", "0-SNAPSHOT"),
   versionScheme := Some("early-semver"),
+  scalacOptions ++= Seq(
+      "-Xfatal-warnings",
+      "-deprecation",
+      "-feature",
+      "-Xlint",
+  )
 ))
 
 publishTo := sonatypePublishToBundle.value

worker/build.sbt

@@ -28,11 +28,7 @@ javaOptions ++= Seq(
   "-Dorg.quartz.properties=quartz.properties"
 )
 
-scalacOptions ++= Seq(
-  "-deprecation",
-  "-feature",
-  "-Xlint"
-)
+scalacOptions += "-Xlint"
 
 Compile / unmanagedClasspath += sourceDirectory.value / "run" / "resources"