Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): update anchor icon #2523

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jamiemlaw
Copy link
Contributor

What is the purpose of this pull request?

  • Other: icon update

Description

Brings Lucide's anchor icon more inline with designs seen elsewhere.

image

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Added or changed icons

icons/anchor.svg

Preview cohesion icons/square-sigma.svg
icons/anchor.svg
icons/bookmark-minus.svg
Preview stroke widths icons/anchor.svg
icons/anchor.svg
icons/anchor.svg
DPI Preview (24px) icons/anchor.svg
Icon X-rays icons/anchor.svg
Icon Diffs icons/anchor.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const AnchorIcon = createLucideIcon('Anchor', [
  ["path",{"d":"M12 6v16"}],
  ["path",{"d":"m19 13 2-1a9 9 0 0 1-18 0l2 1"}],
  ["path",{"d":"M9 11h6"}],
  ["circle",{"cx":"12","cy":"4","r":"2"}]
])

@karsa-mistmere
Copy link
Member

I don't like the density of the arrows.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Oct 8, 2024

I personally like the very minimalist approach of our current anchor icon, if we did want to go more realistic, here are a few alternate proposals:

image

icons icons icons

@jamiemlaw
Copy link
Contributor Author

That first design looks very clean. ❤️

@jguddas
Copy link
Member

jguddas commented Oct 8, 2024

That first design looks very clean. ❤️

Yes, but the corners should be rounded.

@karsa-mistmere
Copy link
Member

Yes, but the corners should be rounded.

I disagree, I did try adding appropriate rounding, but no rounding is best for pixel perfection and density at 1x in this case:

image

(no rounding, .25px, .5px and 1px)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants