Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed bath icon #2512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jamiemlaw
Copy link
Contributor

What is the purpose of this pull request?

  • Other: icon update

Description

The bath icon used a number of verbose <line/> elements, which I have replaced with <path>s. In addition, the curve of the shower head was made up of a bezier curve and an arc, which is now just an arc, with a slightly larger radius.

Before Submitting

Replaced `<line/>` elements with `<path/>`s and refined the curve of the shower head to use fewer path segments and have a larger radius
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Added or changed icons

icons/bath.svg

Preview cohesion icons/square-function.svg
icons/bath.svg
icons/folder-search-2.svg
Preview stroke widths icons/bath.svg
icons/bath.svg
icons/bath.svg
DPI Preview (24px) icons/bath.svg
Icon X-rays icons/bath.svg
Icon Diffs icons/bath.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BathIcon = createLucideIcon('Bath', [
  ["path",{"d":"M10 4 8 6"}],
  ["path",{"d":"M17 19v2"}],
  ["path",{"d":"M2 12h20"}],
  ["path",{"d":"M7 19v2"}],
  ["path",{"d":"M9 5 7.621 3.621A2.121 2.121 0 0 0 4 5v12a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2v-5"}]
])

@jguddas
Copy link
Member

jguddas commented Oct 5, 2024

I would prefer the top arc to be 2px and snapped.
icons
Open lucide studio

@karsa-mistmere
Copy link
Member

I would prefer the top arc to be 2px and snapped. iconsOpen lucide studio

This one has a gap guideline violation though, so I prefer @jamiemlaw's version.

@jguddas
Copy link
Member

jguddas commented Oct 9, 2024

This one has a gap guideline violation though, so I prefer @jamiemlaw's version.

True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants